-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nx 19.2.2 cannot build repo setup for incremental builds #26483
Comments
incremental builds is quite an advertised feature of Nx |
anyone care to comment? this even has a repro.... |
latest 19.5.7 still same! |
Hi @gkamperis I apologise for the delay in a resolution to this issue. I'm taking a look at it now |
@gkamperis The workaround for now is to add the following in your "build": {
"dependsOn": ["^build"]
} |
… is set #26483 (#27616) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When using incremental builds with `@nx/angular:webpack-browser` the dependent libraries need to be built. However, there is no target default to force a build to build dependents. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Add a targetDefault and update docs to reflect this requirement ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26483
… is set #26483 (#27616) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When using incremental builds with `@nx/angular:webpack-browser` the dependent libraries need to be built. However, there is no target default to force a build to build dependents. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Add a targetDefault and update docs to reflect this requirement ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26483 (cherry picked from commit d9fed4b)
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
Instructions followed here do not work
https://nx.dev/recipes/angular/setup-incremental-builds-angular
further more I notice that there is a "tmp" folder created that seems to want to contain the built artefacts instead of the "dist" folder.
This used to work with nx 17 latest and 18 latest
Expected Behavior
The outcome of the described docs
GitHub Repo
https://github.com/gkamperis/nx-incremental-bug
Steps to Reproduce
nx build my-app-m --parallel
Nx Report
Failure Logs
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: