Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspack dev server: error logs not shown #28179

Closed
1 of 4 tasks
dangbert opened this issue Sep 27, 2024 · 1 comment · Fixed by #28429
Closed
1 of 4 tasks

rspack dev server: error logs not shown #28179

dangbert opened this issue Sep 27, 2024 · 1 comment · Fixed by #28429
Assignees
Labels
outdated scope: bundlers Issues related to webpack, rollup type: bug

Comments

@dangbert
Copy link

dangbert commented Sep 27, 2024

Current Behavior

If I create a default nx project with rspack, and induce any compile error (e.g import a file that doesn't exist) the failed compilation is reported by the CLI, but no error message shows up.

image

After a while I figured out I could find the error by visiting the dev server port in the browser:

image

Expected Behavior

The compile error must be logged in the terminal

GitHub Repo

https://github.com/dangbert/nxwarningdemo/tree/error-compiling2

^please use the error-compiling2 branch

Steps to Reproduce

git clone https://github.com/dangbert/nxwarningdemo && cd nxwarningdemo

# checkout the specific branch I made for this issue
git checkout --track origin/error-compiling2
yarn
yarn start

Nx Report

nx                 : 19.8.0
@nx/js             : 19.8.0
@nx/jest           : 19.8.0
@nx/linter         : 19.8.0
@nx/eslint         : 19.8.0
@nx/workspace      : 19.8.0
@nx/cypress        : 19.8.0
@nx/devkit         : 19.8.0
@nx/eslint-plugin  : 19.8.0
@nx/react          : 19.8.0
@nrwl/tao          : 19.8.0
@nx/web            : 19.8.0
@nx/webpack        : 19.8.0
typescript         : 5.5.4
---------------------------------------
Community plugins:
@nx/rspack : 19.7.1

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@jaysoo jaysoo added the scope: bundlers Issues related to webpack, rollup label Oct 14, 2024
@jaysoo jaysoo closed this as completed in 1c466d0 Oct 14, 2024
jaysoo pushed a commit that referenced this issue Oct 14, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
When running serve with Rspack, `stats: false` is being added to
`devMiddleware` preventing logs from being output to the terminal.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure logs are logged to the devServer

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28179
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: bundlers Issues related to webpack, rollup type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants