Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring vite.config temporary files - gitignore doesn't support brace expansion #28685

Closed
1 of 4 tasks
JoA-MoS opened this issue Oct 29, 2024 · 1 comment · Fixed by #28693
Closed
1 of 4 tasks

ignoring vite.config temporary files - gitignore doesn't support brace expansion #28685

JoA-MoS opened this issue Oct 29, 2024 · 1 comment · Fixed by #28693
Assignees

Comments

@JoA-MoS
Copy link
Contributor

JoA-MoS commented Oct 29, 2024

Current Behavior

In recent update added **/vite.config.{js,ts,mjs,mts,cjs,cts}.timestamp* to the .gitignore file but the ignore file doesn't support brace expansion.

also it doesn't need the **/ at the begining of the string which would better follow how previous file ignores have been added.

https://git-scm.com/docs/gitignore

Expected Behavior

file like vite.config.mts.timestamp-1728501368696-41bfd7a885ddf.mjs should be ignored

GitHub Repo

No response

Steps to Reproduce

Run the migrations for 20.0.6 that add the line to the gitignore then create a file and see if it is actually ignored.

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.14.0
OS             : darwin-arm64
Native Target  : aarch64-macos
npm            : 10.7.0

nx (global)        : 20.0.0
nx                 : 20.0.6
@nx/js             : 20.0.6
@nx/jest           : 20.0.6
@nx/eslint         : 20.0.6
@nx/workspace      : 20.0.6
@nx/devkit         : 20.0.6
@nx/eslint-plugin  : 20.0.6
@nx/express        : 20.0.6
@nx/node           : 20.0.6
@nx/vite           : 20.0.6
@nx/vue            : 20.0.6
@nx/web            : 20.0.6
@nx/webpack        : 20.0.6
typescript         : 5.5.4
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx/vite/plugin
@nx/jest/plugin
@nx/webpack/plugin

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

I am not sure the gitignore solution actually solves the core issue.

@Coly010 Coly010 self-assigned this Oct 30, 2024
jaysoo pushed a commit that referenced this issue Oct 31, 2024
 (#28693)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

<!-- This is the behavior we have today -->
The pattern added for .gitignore is incorrect

<!-- This is the behavior we should expect with the changes in this PR
-->
Add the correct pattern

<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28685
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants