You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(#28693)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->
<!-- This is the behavior we have today -->
The pattern added for .gitignore is incorrect
<!-- This is the behavior we should expect with the changes in this PR
-->
Add the correct pattern
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#28685
Current Behavior
In recent update added
**/vite.config.{js,ts,mjs,mts,cjs,cts}.timestamp*
to the.gitignore
file but the ignore file doesn't support brace expansion.also it doesn't need the
**/
at the begining of the string which would better follow how previous file ignores have been added.https://git-scm.com/docs/gitignore
Expected Behavior
file like vite.config.mts.timestamp-1728501368696-41bfd7a885ddf.mjs should be ignored
GitHub Repo
No response
Steps to Reproduce
Run the migrations for 20.0.6 that add the line to the gitignore then create a file and see if it is actually ignored.
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
I am not sure the gitignore solution actually solves the core issue.
The text was updated successfully, but these errors were encountered: