20.0.8 Maximum call stack size exceeded on run-many #28788
Comments
|
Likely caused by #28669 |
|
@yharaskrik Also note that you can safely remove the |
Sounds good thanks, I don't actually have them in my package.json anymore, must still just exist in node_modules. |
|
@yharaskrik it is hard to debug without a repo. Could you generate a project graph or task graph for generate-schema using |
Ya, sorry about that, I know repros are preferred. I will check this out for you right now! |
I looked in the daemon.log but I didn't see anything in there, is there somewhere I could potentially pull a stack trace for you? |
|
i published a pr release 0.0.0-pr-28793-3c45083. could you help me to verify whether this issue is fixed in my pr? |
All fixed! 🎉 |
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - getNonDummyDeps is a recursive function. we pass in cycle arg to this function. currently we end the recursion when the task is in a cycle. however, currently there is an error "Maximum call stack size". i suspect this recursion is not being ended because the cycle is not detected when there are multiple cycles. - add a function to get all cycles of the graph - also, change getNonDummyDeps to track a list of seen tasks, even with no cycle detected, this function will not run into infinite recursion ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28788 (cherry picked from commit 9c24566)
|
How can I still the pr release? I have the same issue an also would like to check if the changes help. |
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - getNonDummyDeps is a recursive function. we pass in cycle arg to this function. currently we end the recursion when the task is in a cycle. however, currently there is an error "Maximum call stack size". i suspect this recursion is not being ended because the cycle is not detected when there are multiple cycles. - add a function to get all cycles of the graph - also, change getNonDummyDeps to track a list of seen tasks, even with no cycle detected, this function will not run into infinite recursion ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28788 (cherry picked from commit 9c24566)
Current Behavior
I recently upgraded to 20.0.7 but then realized there was an issue with dependent projects, but then 20.0.8 was released the fix for that, just tried it this morning but now I am getting
I successfully ran another command prior to this in CI though so its not all commands (
nx run-many -t generate-prisma-client --parallel).Note: this ran find on 20.0.7 so the issue was introduced in 20.0.8
Expected Behavior
Run-many works correctly.
GitHub Repo
No response
Steps to Reproduce
Unsure, would assume it has to do with the graph and possibly a circular dependency.
Nx Report
Failure Logs
Package Manager Version
bun@latest
Operating System
Additional Information
Was working on 20.0.7, broke on 20.0.8
The text was updated successfully, but these errors were encountered: