feat(nx): generating apps works without ng-add #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
approved these changes
Apr 24, 2019
packages/node/src/utils/types.1.ts
Outdated
| @@ -0,0 +1,39 @@ | |||
| import { FileReplacement } from './normalize'; | |||
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior (This is the behavior we have today, before the PR is merged)
Workflow requires
ng-add. Adding dependencies via npm/yarn and then generating apps will fail.Expected Behavior (This is the new behavior we can expect after the PR is merged)
Workflow does not require
ng-add. Users can now add dependencies via npm/yarn and generate apps successfullyIssue