Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schematics): consider ExportDeclaration w/ moduleSpecifier for dependency calculation in v7 #1304

Merged
merged 1 commit into from
May 2, 2019
Merged

fix(schematics): consider ExportDeclaration w/ moduleSpecifier for dependency calculation in v7 #1304

merged 1 commit into from
May 2, 2019

Conversation

dherges
Copy link
Contributor

@dherges dherges commented Apr 28, 2019

Closes #1303

@dherges
Copy link
Contributor Author

dherges commented Apr 28, 2019

Confirm this change lets test run pass as expected in 7.7.2:

$ node_modules/.bin/nx affected:test <..>
Running test for projects:
 ...
Running test for ...
Running test for ...
Running test for ...
Running test for affected projects succeeded.

@FrozenPandaz FrozenPandaz self-requested a review April 29, 2019 15:11
@FrozenPandaz
Copy link
Collaborator

Thanks for your contribution!

LGTM! Just run yarn format to format the code please. 👍

@dherges
Copy link
Contributor Author

dherges commented Apr 30, 2019

@FrozenPandaz will do!

@dherges dherges changed the title fix(nx): consider ExportDeclaration with a moduleSpecifier only for dependency calculation fix(schematics): consider ExportDeclaration with a moduleSpecifier only for dependency calculation Apr 30, 2019
@dherges dherges changed the title fix(schematics): consider ExportDeclaration with a moduleSpecifier only for dependency calculation fix(schematics): consider ExportDeclaration w/ moduleSpecifier for dependency calculation Apr 30, 2019
@dherges dherges mentioned this pull request Apr 30, 2019
Closed
@FrozenPandaz
Copy link
Collaborator

Looks like this is a duplicate of: #1311

@dherges
Copy link
Contributor Author

dherges commented Apr 30, 2019 •
edited
Loading

This is the fix for Nrwl 7.x

#1311 is the fix for Nrwl 8.x

@FrozenPandaz FrozenPandaz reopened this Apr 30, 2019
@dherges dherges changed the title fix(schematics): consider ExportDeclaration w/ moduleSpecifier for dependency calculation fix(schematics): consider ExportDeclaration w/ moduleSpecifier for dependency calculation in v7 May 1, 2019
dherges added a commit to sparkles-dev/sparkles that referenced this pull request May 1, 2019
@dherges
build: patch @nrwl/schematics#1304 and @nrwl/schematics#1318
4964dba 
See nrwl/nx#1318

See nrwl/nx#1304

Resolves build errors on master branch
dherges added a commit to sparkles-dev/sparkles that referenced this pull request May 1, 2019
@dherges
build: patch @nrwl/schematics#1304 and @nrwl/schematics#1318
c203d14 
See nrwl/nx#1318

See nrwl/nx#1304

Resolves build errors on master branch
dherges pushed a commit to sparkles-dev/sparkles that referenced this pull request May 1, 2019
@renovate @dherges
fix: update nrwl monorepo to v7.8.3 (#306)
6c9cfe9 
Also resolves build errors on master branch by patching nx 7.8.3, apply nrwl/nx#1304 and apply nrwl/nx#1318

See nrwl/nx#1318

See nrwl/nx#1304
@vsavkin vsavkin merged commit 9fc6e76 into nrwl:7.8.x May 2, 2019
@dherges dherges deleted the patch-1 branch May 3, 2019 13:52
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dherges @FrozenPandaz @vsavkin