Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add backwards compat support for the ngrx generator #14348

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

leosvelperez
Copy link
Member

Adds support for Angular 14 in the latest version of Nx to the ngrx generator.

@leosvelperez leosvelperez requested a review from Coly010 January 13, 2023 15:37
@leosvelperez leosvelperez self-assigned this Jan 13, 2023
@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 5:26PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should we maybe add a comment in the versions.ts file to say all properties referring to a package to install must have the same name / identifier?

@leosvelperez
Copy link
Member Author

@Coly010 good point. Will look into adding some form of type-checking in a follow-up PR.

@leosvelperez leosvelperez merged commit 295547b into nrwl:master Jan 13, 2023
@leosvelperez leosvelperez deleted the angular/ngrx-ng14-support branch January 13, 2023 18:51
FrozenPandaz pushed a commit that referenced this pull request Jan 17, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants