-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devkit): always read package version from the actual package in e… #14623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
requested changes
Jan 25, 2023
jaysoo
force-pushed
the
fix/ensure-package-util
branch
from
January 25, 2023 19:38
4db58f5
to
6623e60
Compare
AgentEnder
approved these changes
Jan 25, 2023
jaysoo
force-pushed
the
fix/ensure-package-util
branch
from
January 25, 2023 20:40
6623e60
to
3825dd6
Compare
jaysoo
force-pushed
the
fix/ensure-package-util
branch
from
January 25, 2023 22:19
3825dd6
to
c2827ba
Compare
…nsurePackage function
jaysoo
force-pushed
the
fix/ensure-package-util
branch
from
January 25, 2023 22:25
c2827ba
to
e2ff565
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsurePackage function
Currently, if there is a range in the root
package.json
file, theensurePackage
function does not work, since comparing something like^1.0.0
to1.0.0
will not work. This PR fixes this by looking at the actual version installed rather than a range.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #