Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): always read package version from the actual package in e… #14623

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 25, 2023

…nsurePackage function

Currently, if there is a range in the root package.json file, the ensurePackage function does not work, since comparing something like ^1.0.0 to 1.0.0 will not work. This PR fixes this by looking at the actual version installed rather than a range.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 10:36PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2ff565. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following targets are in progress

✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@jaysoo jaysoo force-pushed the fix/ensure-package-util branch from c2827ba to e2ff565 Compare January 25, 2023 22:25
@jaysoo jaysoo merged commit 243b742 into nrwl:master Jan 25, 2023
@jaysoo jaysoo deleted the fix/ensure-package-util branch January 25, 2023 23:14
FrozenPandaz pushed a commit that referenced this pull request Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants