Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx): add ability to ignore files from affected commands #1585

Merged
merged 1 commit into from
Aug 29, 2019
Merged

feat(nx): add ability to ignore files from affected commands #1585

merged 1 commit into from
Aug 29, 2019

Conversation

wesleygrimes
Copy link
Contributor

@wesleygrimes wesleygrimes commented Jul 15, 2019

Check .nxignore for globs to add to ignored files in affected commands

Please make sure you have read the submission guidelines before posting an PR

Please make sure that your commit message follows our format.

Example: fix(nx): must begin with lowercase

Current Behavior (This is the behavior we have today, before the PR is merged)

Affected commands ignore files/folders in .gitignore

Expected Behavior (This is the new behavior we can expect after the PR is merged)

Affected commands ignore files/folders in .gitignore and .nxignore

Issue

Implement #895

@wesleygrimes
Copy link
Contributor Author

wesleygrimes commented Jul 15, 2019

This is WIP, need to update documentation to mention new ability to provide .nxignore and ignore property in nx.json.

@wesleygrimes wesleygrimes marked this pull request as ready for review July 15, 2019 17:59
@wesleygrimes
Copy link
Contributor Author

@vsavkin updated react and web guides to mention ignore feature

@wesleygrimes
Copy link
Contributor Author

Looks like the build/test on travis failing because of some cached files for cypress.

@brandonroberts
Copy link
Contributor

brandonroberts commented Jul 17, 2019

You can delete the cache for your PR by clicking on the "More Options" menu and going to caches. Then restart the job

@wesleygrimes
Copy link
Contributor Author

You can delete the cache for your PR by clicking on the "More Options" menu and going to caches. Then restart the job

Looks like I don't have access rights to do that. Unless I am missing something.

Screen Shot 2019-07-17 at 9 05 44 AM

@vsavkin
Copy link
Member

vsavkin commented Aug 6, 2019

@wesleygrimes could you rebase it? Sorry about it.

@wesleygrimes
Copy link
Contributor Author

@wesleygrimes could you rebase it? Sorry about it.

Sure. Will do.

Copy link
Member

@vsavkin vsavkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should support both .nxignore and the ignore property in nx.json. They do the same thing.

I'd just add support for .nxignore. Then, the PR will be a lot smaller.

docs/angular/fundamentals/monorepos-automation.md Outdated Show resolved Hide resolved
docs/web/fundamentals/monorepos-automation.md Outdated Show resolved Hide resolved
@wesleygrimes
Copy link
Contributor Author

Ready for review

Add ability to ignore files from the affected check using .nxignore files

Implement #895
@vsavkin vsavkin force-pushed the master branch 2 times, most recently from 3569a53 to 54d5826 Compare August 21, 2019 15:53
@vsavkin vsavkin merged commit 929aeb7 into nrwl:master Aug 29, 2019
@johannesschobel
Copy link
Contributor

This, somehow does not work for me. I added a .nxignore file in the root-folder of my workspace and added the line **/generated in order to exclude all files in generated folders in my projects.
While this works for the .gitignore, the generated/*.ts files are still linted during my npm run affected:lint command - resulting in errors :(

Any solution for this?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants