-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx): add ability to ignore files from affected commands #1585
feat(nx): add ability to ignore files from affected commands #1585
Conversation
This is WIP, need to update documentation to mention new ability to provide |
@vsavkin updated |
Looks like the build/test on travis failing because of some cached files for cypress. |
You can delete the cache for your PR by clicking on the "More Options" menu and going to caches. Then restart the job |
@wesleygrimes could you rebase it? Sorry about it. |
Sure. Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should support both .nxignore and the ignore property in nx.json. They do the same thing.
I'd just add support for .nxignore. Then, the PR will be a lot smaller.
Ready for review |
Add ability to ignore files from the affected check using .nxignore files Implement #895
3569a53
to
54d5826
Compare
This, somehow does not work for me. I added a Any solution for this? |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Check .nxignore for globs to add to ignored files in affected commands
Please make sure you have read the submission guidelines before posting an PR
Current Behavior (This is the behavior we have today, before the PR is merged)
Affected commands ignore files/folders in .gitignore
Expected Behavior (This is the new behavior we can expect after the PR is merged)
Affected commands ignore files/folders in .gitignore and .nxignore
Issue
Implement #895