fix(nx): rename browserlist file to browserslist #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [the Browserslist docs](https://github.com/browserslist/browserslist#queries), the file should be named `browserslist`. The previous name had a missing "s" in the middle. I do not know how `browserslist` is integrated in Nx and the Angular CLI, but it is possible that the configuration file was being ignored entirely due to this naming error. When the `browserslist` CLI does not find a configuration file, it uses a sensible default configuration, so it would not be obvious that the configuration file was ignored.
FrozenPandaz
approved these changes
Aug 1, 2019
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(nx): rename browserlist file to browserslist
According to the Browserslist docs,
the file should be named
browserslist. The previous name had a missing"s" in the middle.
I do not know how
browserslistis integrated in Nx and the AngularCLI, but it is possible that the configuration file was being ignored
entirely due to this naming error. When the
browserslistCLI does notfind a configuration file, it uses a sensible default configuration, so
it would not be obvious that the configuration file was ignored.