Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): dont fail if targets dont exist #18745

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Aug 21, 2023

Current Behavior

If there is no targets object in project.json then generator fails.

Expected Behavior

If there is no targets object in project.json generator should not fail.

Related Issue(s)

Fixes #18725

@mandarini mandarini requested a review from a team as a code owner August 21, 2023 14:54
@mandarini mandarini requested a review from Coly010 August 21, 2023 14:54
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 2:59pm

@mandarini mandarini self-assigned this Aug 21, 2023
@mandarini mandarini merged commit 0448317 into nrwl:master Aug 21, 2023
3 checks passed
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request Aug 21, 2023
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request Aug 21, 2023
FrozenPandaz pushed a commit that referenced this pull request Aug 21, 2023
@mandarini mandarini deleted the fix/storybook-empty-targets branch August 22, 2023 12:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting up for Storybook not working
2 participants