Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): fix normalizing e2e project name and root #18757

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Some project generators that generate an e2e test project when using the new project name and root format (as-provided) and providing a directory throw an error. It happens because the directory provided to the helper function is the directory of the app. With the as-provided format, that's where the project is going to be generated, but the app project is there.

Expected Behavior

Project generators that generate an e2e test project should normalize the e2e project name and root correctly and not throw.

When the e2e project name and root is determined we already know the fully normalized app name and root. So, the e2e project name and root can be easily determined without using the helper.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Aug 22, 2023
@leosvelperez leosvelperez requested review from a team as code owners August 22, 2023 08:40
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 8:45am

@leosvelperez leosvelperez merged commit b3a0c0e into nrwl:master Aug 22, 2023
3 checks passed
@leosvelperez leosvelperez deleted the misc/fix-normalizing-e2e-name-root branch August 22, 2023 14:33
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants