fix(linter): error on dependencies that are only in devDependencies instead of production dependencies

[jaysoo]

This PR makes it so that packages listed under devDependencies are not counted as correct. User must add the dependency to dependencies, peerDependencies, or optionalDependencies since devDependencies are not installed for the end user (consumer of the published project).

For example, say I have a project with this package.json:

{
  // ...
  "devDependencies": {
    "foo": "1.0.0"
  }
}

And in my project I have import 'foo' somewhere in the source code.

In the existing version of the dep checks rule, it will not error out. However, if a consumer installed my published package, they will get an error because foo package is not installed. The fix in this PR will force the user to move foo to dependencies, peerDependencies, or optionalDependencies.

Current Behavior

Adding a dependency to devDependencies satisfies the dep check.

Expected Behavior

Dependency cannot only be in devDependencies.

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2023 7:32pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b66a3a8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• linux nx affected --target=e2e --base=d1da057811a06fa3a17aed9001fc17c299fe718a --head=b66a3a8dac165bfd27bf44a4af06ca2e53821d89 --parallel=1
• linux nx affected --target=build --base=d1da057811a06fa3a17aed9001fc17c299fe718a --head=b66a3a8dac165bfd27bf44a4af06ca2e53821d89 --parallel=3
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=lint --base=d1da057811a06fa3a17aed9001fc17c299fe718a --head=b66a3a8dac165bfd27bf44a4af06ca2e53821d89 --parallel=3
• linux nx affected --target=test --base=d1da057811a06fa3a17aed9001fc17c299fe718a --head=b66a3a8dac165bfd27bf44a4af06ca2e53821d89 --parallel=1
• nx-cloud record -- nx format:check --base=d1da057811a06fa3a17aed9001fc17c299fe718a --head=b66a3a8dac165bfd27bf44a4af06ca2e53821d89
• linux nx documentation --no-dte
• macos nx affected -t e2e-macos --parallel=1 --base=d1da057811a06fa3a17aed9001fc17c299fe718a --head=b66a3a8dac165bfd27bf44a4af06ca2e53821d89

---

Sent with 💌 from NxCloud.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.