Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): update to jest-preset-angular v8.0.0 #2401

Merged
merged 3 commits into from
Feb 1, 2020
Merged

feat(testing): update to jest-preset-angular v8.0.0 #2401

merged 3 commits into from
Feb 1, 2020

Conversation

FrozenPandaz
Copy link
Collaborator

Credits

Huge thank you to @mehrad-rafigh and @JoshMentzer for handling this change.

Current Behavior (This is the behavior we have today, before the PR is merged)

  • jest-preset-angular is v7.0.0
  • Upgrading jest-preset-angular to v8.0.0 causes any tests for Angular projects using Jest to fail to run

Expected Behavior (This is the new behavior we can expect after the PR is merged)

  • jest-preset-angular is v8.0.0
  • Tests for Angular projects using Jest should execute successfully

Issue

Closes #1979
Closes #2165
Closes #1986
Closes #2250

@FrozenPandaz FrozenPandaz marked this pull request as ready for review January 31, 2020 03:15
@FrozenPandaz FrozenPandaz changed the title [WIP] feat(testing): update to jest-preset-angular v8.0.0 feat(testing): update to jest-preset-angular v8.0.0 Jan 31, 2020
@FrozenPandaz FrozenPandaz requested a review from vsavkin January 31, 2020 03:15
mentzerj and others added 2 commits January 31, 2020 13:12
@mentzerj @FrozenPandaz
feat(testing): update to jest-preset-angular v8.0.0 part 1
c856bba 
Updates to jest-preset-angular to v8.0.0, includes migrations to fix any existing projects affected
by the jest-preset-angular update.

closes nrwl#1979
@mehrad-rafigh @mentzerj @FrozenPandaz
feat(testing): update jest-preset-angular to v8.0.0 part 2
ebc33da 
Closed issues: nrwl#1979, nrwl#2165

Co-authored-by: Joshua D. Mentzer <mentzerj@trinity-health.org>
@FrozenPandaz FrozenPandaz force-pushed the jest branch 2 times, most recently from ac5bfbb to ae629af Compare January 31, 2020 21:30
@FrozenPandaz FrozenPandaz merged commit 972381b into nrwl:master Feb 1, 2020
@maartentibau
Copy link

maartentibau commented Feb 2, 2020 •
edited
Loading

Is there a way to already use this fix in the latest v8 release of Nx?

I would like to use it because with every ng update command I'm doing I always get a security report, and it is always related to the version of jest-preset-angular which would be solved with this PR landing in master.

Screen Shot 2020-02-02 at 10 12 02

@robin-rpr
Copy link

@maartentibau Update @nrwl/jest in your package.json to 9.0.0-beta.1

@maartentibau
Copy link

@maartentibau Update @nrwl/jest in your package.json to `9.0.0-beta.1

Since the release of version 9 I don't have the problem anymore. But thanks for your reply.

@neilsoult
Copy link

Sorry for the gravedigging, but since the documentation says that our Nx version should match our angular project version (we are still running angular 8), is there any hope for this fix being added to a nx 8 version? Or is it ok to use the latest version of Nx with an angular 8 project?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jest 8.0 jest-preset-angular v8 has breaking changes
6 participants
@FrozenPandaz @maartentibau @robin-rpr @neilsoult @mentzerj @mehrad-rafigh