fix(core): fixes an issue where using "node:test" results in infinite loop #27685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jaysoo
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 822cbf2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
requested changes
Aug 28, 2024
packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
Outdated
Show resolved
Hide resolved
| // These are missing in the builtinModules list | ||
| // See: https://github.com/nodejs/node/issues/42785 | ||
| // TODO(v20): We should be safe to use `isBuiltin` function instead of keep the set here (https://nodejs.org/api/module.html#moduleisbuiltinmodulename) | ||
| 'test', |
There was a problem hiding this comment.
Let's add a unit test for test and node:test.
Can you add sqlite and sea while you're at it?
There was a problem hiding this comment.
Sure, node:sea exists, sea does not so I'll add the former.
FrozenPandaz
approved these changes
Aug 28, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 28, 2024
… loop (#27685) This PR fixes an issue with `node:test` not being recognized as a built-in Node module, and since it is not in `node_modules` with a resolvable `package.json`, it hits an infinite loop. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit e28de09)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
node:testnot being recognized as a built-in Node module, and since it is not innode_moduleswith a resolvablepackage.json, it hits an infinite loop.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #