Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): take nx-release-publish target defaults into account for implicit target #27764

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Sep 4, 2024

Current Behavior

We to not take targetDefaults into account when creating the implicit target for nx-release-publish.

Expected Behavior

We take targetDefaults into account when creating the implicit target for nx-release-publish.

Related Issue(s)

Fixes #27749

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Sep 4, 2024 0:29am

@JamesHenry JamesHenry marked this pull request as ready for review September 5, 2024 20:42
@JamesHenry JamesHenry requested a review from a team as a code owner September 5, 2024 20:42
@JamesHenry JamesHenry self-assigned this Sep 9, 2024
@JamesHenry JamesHenry merged commit 44da27d into master Sep 10, 2024
6 checks passed
@JamesHenry JamesHenry deleted the nx-release-publish-target-defaults branch September 10, 2024 14:35
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx-release-publish default target dependsOn is ignored
2 participants