Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): enable composite graph functionality #27789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Sep 5, 2024

This PR enables composite graph functionality:

  • Experimental feature to enable Composite Graph
  • In Composite Graph mode:
    • Nodes are shown by default.
    • Show/Hide All Projects function similarly to regular mode
    • Focus a Composite Node renders the inner nodes with up-to 3 additional containers: Green area contains external nodes that depend on the inner nodes; Orange area contains external nodes that the inner nodes depend depend on; Purple area contains external nodes with circular dependencies with the inner nodes.
      • Focused node can be unfocus/reset.
      • Only one node can be focused at one given time. - Show All projects while having a focused node will unfocus the node.
    • Expand a Composite Node renders the inner nodes of the composite node in-place (i.e: still keep the context of the current graph). Expanded node can be collapsed to go back.

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 20, 2024 7:25pm

@nartc nartc self-assigned this Sep 5, 2024
@MaxKless
Copy link
Collaborator

Found an error:
image

steps to repro:

  • nx run graph-client:serve
  • focus on packages composite view
  • exclude ./e2e
  • exclude ./packages-legacy
  • try to expand ./tools
  • -> see error

This PR enables composite graph functionality:
- Experimental feature to enable Composite Graph
- In Composite Graph mode:
  - Nodes are shown by default.
  - Show/Hide All Projects function similarly to regular mode
  - Focus a Composite Node renders the inner nodes with up-to 3
additional containers: Green area contains external nodes that depend on
the inner nodes; Orange area contains external nodes that the inner
nodes depend depend on; Purple area contains external nodes with
circular dependencies with the inner nodes.
    - Focused node can be unfocus/reset.
    - Only one node can be focused at one given time.
    - Show All projects while having a focused node will unfocus the
node.
  - Expand a Composite Node renders the inner nodes of the composite
node in-place (i.e: still keep the context of the current graph).
Expanded node can be collapsed to go back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants