feat(graph): expose functions to render pdv & error page #27833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
requested review from
philipjfulcher,
FrozenPandaz,
bcabanes and
xiongemi
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 18fd642. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
pdv-rendering
branch
from
0eec6ba
to
45a5680
Compare
MaxKless
force-pushed
the
pdv-rendering
branch
from
45a5680
to
b400832
Compare
jaysoo
requested changes
Sep 11, 2024
graph/ui-project-details/src/lib/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
graph/ui-project-details/src/lib/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
graph/ui-project-details/src/lib/project-details/project-details.tsx
Outdated
Show resolved
Hide resolved
graph/ui-project-details/src/lib/project-info-header/project-info-header.tsx
Outdated
Show resolved
Hide resolved
jaysoo
reviewed
Sep 11, 2024
MaxKless
force-pushed
the
pdv-rendering
branch
from
9877523
to
29c76a9
Compare
jaysoo
force-pushed
the
pdv-rendering
branch
2 times, most recently
from
25b5c24
to
a5bb0e9
Compare
jaysoo
approved these changes
Sep 12, 2024
jaysoo
force-pushed
the
pdv-rendering
branch
from
a5bb0e9
to
c9bf963
Compare
…rPDV & renderError
MaxKless
force-pushed
the
pdv-rendering
branch
from
1bbc8f9
to
18fd642
Compare
|
I tested this on latest and canary Nx releases. Can verify that everything is working with the old |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have fully isolated graph & error components with a good api but no way to access them directly from the outside (in console).
This PR adds two functions to the window object so that we can render the PDV directly instead of needing the entire app with routing and everything.