fix(core): link to sync generators page during sync prompt, and provide more info on docs page for disabling and applyChanges #28001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
commented
Sep 19, 2024
| @@ -110,7 +111,7 @@ export function ProjectDetails({ | |||
| )} | |||
| <div | |||
| id="project-details-container" | |||
| className="not-prose overflow-y-auto" | |||
| className={twMerge('not-prose', height && 'overflow-y-auto')} | |||
There was a problem hiding this comment.
There was a scrollbar being rendered for me. We don't need to add overflow unless the height property is set.
jaysoo
commented
Sep 19, 2024
| @@ -488,7 +488,7 @@ async function promptForApplyingSyncGeneratorChanges(): Promise<boolean> { | |||
| name: 'applyChanges', | |||
| type: 'select', | |||
| message: | |||
| 'Would you like to sync the identified changes to get your worskpace up to date?', | |||
| 'Would you like to sync the identified changes to get your workspace up to date?', | |||
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 05b1335. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
requested changes
Sep 19, 2024
jaysoo
changed the title
jaysoo
force-pushed
the
feat/sync-docs-and-links
branch
from
10ea3e9
to
546974d
Compare
…ide more info on docs page for disabling and applyChanges
jaysoo
force-pushed
the
feat/sync-docs-and-links
branch
from
546974d
to
05b1335
Compare
FrozenPandaz
approved these changes
Sep 19, 2024
leosvelperez
approved these changes
Sep 19, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the concept page for sync generators to show config examples for
applyChangesanddisableTaskSyncGenerators. It also adds a link when during the sync prompt for users to read more about it.Preview: https://nx-dev-git-feat-sync-docs-and-links-nrwl.vercel.app/concepts/sync-generators
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #