fix(expo): pnpm+workspace build #28209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 951a2e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
dearlordylord
commented
Oct 1, 2024
| @@ -114,7 +114,7 @@ function copyPackageJsonAndLock( | |||
| packageManager: PackageManager, | |||
| workspaceRoot: string, | |||
| projectRoot: string | |||
| ) { | |||
| ): () => void { | |||
There was a problem hiding this comment.
to make not possible to forget again
Closed
4 tasks
Balance8
approved these changes
Oct 16, 2024
xiongemi
approved these changes
Oct 17, 2024
jaysoo
pushed a commit
that referenced
this pull request
Oct 17, 2024
## Current Behavior build executors for expo crash when package manager pnpm and workspaces are used ## Expected Behavior no crashies ## Related Issue(s) #28208 Fixes #28208 ## FAQ - why not handle the `undefined` by the calling code instead The less the calling code knows about inner workings, the better: in this case, doing this would add the implicit dependency on "pnpm and workspaces" to the calling code - but it's an empty function, my performance We call it once per user interaction. - but still, it's an empty function We return an `empty array` when there are no elements; we don't return `undefined` when the array is empty and `array` when array is non-empty. Hopefully so. - but, The doc also says that this function returns a function.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
build executors for expo crash when package manager pnpm and workspaces are used
Expected Behavior
no crashies
Related Issue(s)
#28208
Fixes #28208
FAQ
undefinedby the calling code insteadThe less the calling code knows about inner workings, the better: in this case, doing this would add the implicit dependency on "pnpm and workspaces" to the calling code
We call it once per user interaction.
We return an
empty arraywhen there are no elements; we don't returnundefinedwhen the array is empty andarraywhen array is non-empty. Hopefully so.The doc also says that this function returns a function.