fix(module-federation): additionalShared should check node_modules when applying to support transitive deps #28137 #28216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Transitive deps may not exist on the project graph or be installed in the root package.json file.
They could require the singleton pattern and should use the
additionalShared
functionality.However, the additionalShared will check project graph and root package.json, erroring if the package cannot be found.
The last resort should be to use
require.resolve
to check the node_modules folder to find the package.json of the package and select a version from it.Expected Behavior
Related Issue(s)
Fixes #28137