Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): build w/package.json overrides/resolutions #28254

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

franzmoro
Copy link
Contributor

Current Behavior

When running nx build expo-app, the build executor copies dependencies and devDependencies of the workspace package.json (see copyPackageJsonAndLock function).

The build executor does not copy the resolutions object (for yarn) nor the overrides object (for npm).

Expected Behavior

The build executor copies the overrides object or the resolutions object, if present in the package.json. The original project package.json is restored after the build is completed successfully or after it errors.

Related Issue(s)

#28249

Fixes #

@franzmoro franzmoro requested a review from a team as a code owner October 2, 2024 18:53
@franzmoro franzmoro requested a review from xiongemi October 2, 2024 18:53
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 0:26am

@franzmoro
Copy link
Contributor Author

failing CI does not give any description:

 NX   Nx is executing your tasks and will print a summary upon completion.

packages/expo/src/executors/build/build.impl.ts




 NX   Nx Cloud: Successfully recorded command output

You can view or share your output by visiting https://staging.nx.app/runs/5SS4XXA4fC


Exited with code exit status 1

visiting that url does not help much

nx format:check --base=69109e48d9c5e951c110ab16a9fb07ec95862e36 --head=cf24d591e9e65cb2f0021029714477121b015bea

packages/expo/src/executors/build/build.impl.ts

It's not clear what's wrong.

@franzmoro
Copy link
Contributor Author

@xiongemi could you advise on what is wrong with this CI? No useful info is provided when clicking on the failed jobs.
#28254 (comment)

@xiongemi xiongemi enabled auto-merge (squash) October 11, 2024 00:23
@xiongemi xiongemi merged commit 37a7eb1 into nrwl:master Oct 11, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants