fix(module-federation): remote names should follow JS variable naming schema #28401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 78a8128. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
changed the title
Coly010
requested review from
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
Coly010
force-pushed
the
module-federation/disallow-remotes-with-dash
branch
from
9911b96 to
5823e47
Compare
This was referenced Oct 14, 2024
jaysoo
approved these changes
Oct 14, 2024
jaysoo
added a commit
that referenced
this pull request
Oct 14, 2024
… schema (#28401) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> We previously had a schema restriction on the characters allowed for remote names. It was to prevent names that violated the JS spec for a variable declaration. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Ensure invalid project names fail error allowing the user to fix it at generation ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28354, #28408 --------- Co-authored-by: Jack Hsu <jack.hsu@gmail.com>
This was referenced Oct 15, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We previously had a schema restriction on the characters allowed for remote names. It was to prevent names that violated the JS spec for a variable declaration.
Expected Behavior
Ensure invalid project names fail error allowing the user to fix it at generation
Related Issue(s)
Fixes #28354, #28408