Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): use resolveConfig instead of loadConfigFromFile to ensure node env set #27627 #28444

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 15, 2024

Current Behavior

In the Vite Build Executor, we're using loadConfigFromFile from Vite to get the config options.
The issue with this is that vite will not attempt to set NODE_ENV which may be required by both the config file that is being loaded, and other plugins.

Expected Behavior

Use resolveConfig which does set NODE_ENV correctly

Related Issue(s)

Fixes #27627

@Coly010 Coly010 requested a review from a team as a code owner October 15, 2024 10:30
@Coly010 Coly010 requested a review from ndcunningham October 15, 2024 10:30
@Coly010 Coly010 self-assigned this Oct 15, 2024
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 10:36am

@jaysoo jaysoo merged commit f9f3de0 into master Oct 17, 2024
6 checks passed
@jaysoo jaysoo deleted the vite/set-node-env-when-resolving-config branch October 17, 2024 16:26
jaysoo pushed a commit that referenced this pull request Oct 17, 2024
…node env set #27627 (#28444)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
In the Vite Build Executor, we're using `loadConfigFromFile` from Vite
to get the config options.
The issue with this is that vite will not attempt to set `NODE_ENV`
which may be required by both the config file that is being loaded, and
other plugins.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Use resolveConfig which does set NODE_ENV correctly


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27627
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/vite:build doesn't set NODE_ENV properly
2 participants