Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add migration to set useLegacyCache by default #28454

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Oct 15, 2024

Current Behavior

Existing workspaces that migrate to v20 use the db cache by default.

Expected Behavior

Existing workspaces that migrate to v20 have useLegacyCache set to true. Unless they specifically had enableDbCache from previous versions of Nx. All new workspaces will not have useLegacyCache set by default.

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner October 15, 2024 18:14
@Cammisuli Cammisuli requested a review from xiongemi October 15, 2024 18:14
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 7:14pm

@Cammisuli Cammisuli force-pushed the disable-db-cache-for-migrating-workspaces branch from a24ec2c to 22f93ad Compare October 15, 2024 18:19
@Cammisuli Cammisuli enabled auto-merge (squash) October 15, 2024 18:51
@jaysoo jaysoo disabled auto-merge October 15, 2024 18:53
@JamesHenry JamesHenry enabled auto-merge (squash) October 15, 2024 19:53
@JamesHenry JamesHenry merged commit 72292c7 into master Oct 15, 2024
6 checks passed
@JamesHenry JamesHenry deleted the disable-db-cache-for-migrating-workspaces branch October 15, 2024 20:05
@sleeyax
Copy link

sleeyax commented Oct 21, 2024

Is it possible to migrate an existing workspace to the db cache instead? Can't seem to find this documented anywhere.

@JamesHenry
Copy link
Collaborator

@sleeyax Just migrate to Nx 20 as normal, and remove this useLegacyCache flag from your nx.json if it is present. I would advise running nx reset any time after your make changes related to the cache (such as adding or removing this flag).

@sleeyax
Copy link

sleeyax commented Oct 21, 2024

Gotcha, thanks for the info!

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants