Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): not install cypress when e2e is playwright for react monorepo preset #28642

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Oct 25, 2024

Current Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner October 25, 2024 17:54
@xiongemi xiongemi requested a review from Cammisuli October 25, 2024 17:54
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 1:01am

@xiongemi xiongemi force-pushed the fix/fix-preset-add-extra-packages branch from 924730c to f0c9cd4 Compare October 25, 2024 18:08
@xiongemi xiongemi changed the title fix(core): remove unnecessary packages from workspace preset fix(core): not install cypress when e2e is playwright for react monorepo preset Oct 25, 2024
@xiongemi xiongemi force-pushed the fix/fix-preset-add-extra-packages branch from f0c9cd4 to e19b90f Compare October 29, 2024 00:58
@xiongemi xiongemi merged commit c0c7ad7 into master Oct 29, 2024
6 checks passed
@xiongemi xiongemi deleted the fix/fix-preset-add-extra-packages branch October 29, 2024 17:46
jaysoo pushed a commit that referenced this pull request Oct 31, 2024
…repo preset (#28642)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

Co-authored-by: Benjamin Cabanes <3447705+bcabanes@users.noreply.github.com>
Copy link

github-actions bot commented Nov 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants