Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): retry more db operations #28667

Merged
merged 7 commits into from
Oct 30, 2024
Merged

fix(core): retry more db operations #28667

merged 7 commits into from
Oct 30, 2024

Conversation

Cammisuli
Copy link
Member

  • Introduce new transaction and pragma_update methods in NxDbConnection
  • Refactor initialize_db to handle new conditions
  • Update record_task_details to use transactions
  • Add unit tests for initialize_db

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

- Introduce new `transaction` and `pragma_update` methods in `NxDbConnection`
- Refactor `initialize_db` to handle new conditions
- Update `record_task_details` to use transactions
- Add unit tests for `initialize_db`
@Cammisuli Cammisuli requested review from a team, FrozenPandaz and vsavkin as code owners October 28, 2024 18:39
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 1:47pm

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-28667-e5533b1 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28667-e5533b1
Release details 📑
Published version 0.0.0-pr-28667-e5533b1
Triggered by @Cammisuli
Branch handle-retries-better
Commit e5533b1
Workflow run 11561991465

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-28667-309c668 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28667-309c668
Release details 📑
Published version 0.0.0-pr-28667-309c668
Triggered by @Cammisuli
Branch handle-retries-better
Commit 309c668
Workflow run 11574910702

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-28667-37ba4e7 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28667-37ba4e7
Release details 📑
Published version 0.0.0-pr-28667-37ba4e7
Triggered by @Cammisuli
Branch handle-retries-better
Commit 37ba4e7
Workflow run 11576677751

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-28667-6ebc1cd my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28667-6ebc1cd
Release details 📑
Published version 0.0.0-pr-28667-6ebc1cd
Triggered by @Cammisuli
Branch handle-retries-better
Commit 6ebc1cd
Workflow run 11580246742

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

packages/nx/src/native/db/connection.rs Outdated Show resolved Hide resolved
packages/nx/src/native/db/initialize.rs Show resolved Hide resolved
@Cammisuli Cammisuli enabled auto-merge (squash) October 30, 2024 14:08
@Cammisuli Cammisuli disabled auto-merge October 30, 2024 15:45
@Cammisuli Cammisuli merged commit 63b745e into master Oct 30, 2024
6 checks passed
@Cammisuli Cammisuli deleted the handle-retries-better branch October 30, 2024 15:45
jaysoo pushed a commit that referenced this pull request Oct 31, 2024
jaysoo pushed a commit that referenced this pull request Oct 31, 2024
jaysoo pushed a commit that referenced this pull request Oct 31, 2024
Copy link

github-actions bot commented Nov 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants