Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): breadcrumbs extra text with query param #28732

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

isaacplmann
Copy link
Collaborator

Breadcrumb component was incorrectly showing extra text when the url has a query parameter.

@isaacplmann isaacplmann requested a review from a team as a code owner October 31, 2024 17:51
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 31, 2024 6:05pm

@isaacplmann isaacplmann force-pushed the nx-dev/breadcrumb-query-params branch from 8192bf7 to f087f8d Compare October 31, 2024 17:52
@isaacplmann isaacplmann merged commit d960ddd into master Oct 31, 2024
6 checks passed
@isaacplmann isaacplmann deleted the nx-dev/breadcrumb-query-params branch October 31, 2024 18:55
jaysoo pushed a commit that referenced this pull request Oct 31, 2024
Breadcrumb component was incorrectly showing extra text when the url has
a query parameter.
Copy link

github-actions bot commented Nov 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants