-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-plugin): added support for vitest test runner #29140
feat(nx-plugin): added support for vitest test runner #29140
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 3540033.
☁️ Nx Cloud last updated this comment at |
3b1052d
to
fc930ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs changes look good
8f8841b
to
47ddfdd
Compare
Hi @FrozenPandaz, can you please take a look at this when you have some time? 🙏🏻 |
199ddf4
to
c7cef07
Compare
c7cef07
to
5456d78
Compare
Folks let me know if any change it's required before merge this 🙏🏻 ... |
0dea15c
to
5fb2756
Compare
5fb2756
to
babee77
Compare
05289c9
to
5f2a8af
Compare
5f2a8af
to
eeefd52
Compare
Hi folks... Can you merge this please? have been passed two weeks since was approved 🙏🏻 |
I approved it for the docs changes, but @FrozenPandaz needs to review this to decide if the change makes technical sense and if we want to take on the maintenance of the change, etc. Sorry if my approval communicated more of a positive indicator than it actually carried. I was just approving to make sure that I wasn't blocking the PR. |
Yeah don't worry @isaacplmann and thank you for your quick response... Just to clarify, my intention with this change is reduce the dependency on jest using vitest everywhere... |
eeefd52
to
d26265d
Compare
Your CI Pipeline Execution ↗ for commit a8be3ff is in progress ⏳
☁️ Nx Cloud last updated this comment at |
d26265d
to
b996500
Compare
b996500
to
2fdccaf
Compare
2fdccaf
to
a8be3ff
Compare
a8be3ff
to
f1e9145
Compare
f1e9145
to
4036082
Compare
4036082
to
3540033
Compare
I believe the generated test files for vitest would not make sense? Vitest requires importing describe, it, etc and those are not imported in the specs. If we want to add this support, we need to make sure that running a generator's tests will work out of the box |
@AgentEnder works without importing describe or other stuff from vitest, I published a local version using verdaccio and create a workspace and new plugins project without issues |
Current Behavior
Nx Plugin do not have the option to use Vitest as test runner
Expected Behavior
This PR allow us to use Vitest as test runner in plugins projects.
Vitest for e2e targets is still missing and a new PR will be raised after #29139 is fixed
Related Issue(s)
Fixes #22882