fix(js): switch from fast-glob to tinyglobby

[benmccann]

Current Behavior

17 dependencies: https://npmgraph.js.org/?q=fast-glob

Expected Behavior

2 dependencies: https://npmgraph.js.org/?q=tinyglobby

Related Issue(s)

es-tooling/ecosystem-cleanup#117

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Dec 9, 2024 9:44pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5848e0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=lint,test,build,e2e,e2e-ci --base=d8d74da9fb7895f774b6cdaad0bb280cdc42ea4f --head=5848e0f485121f79f8d3a87ba2c7f07e3adbf251 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx-cloud conformance:check
• nx-cloud record -- nx format:check --base=d8d74da9fb7895f774b6cdaad0bb280cdc42ea4f --head=5848e0f485121f79f8d3a87ba2c7f07e3adbf251
• nx-cloud record -- nx sync:check
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[JamesHenry]

Thanks @benmccann got some task failures to take a look

[benmccann]

Thanks @JamesHenry. When I run pnpm install it's not updating the package-lock.json file. Is there some special setup this repository has around that? It seems the be the cause of the CI errors. I'm not sure if this is just some issue specific to my machine. If you're not familiar with this issue, any chance you could push a commit updating the lockfile for me?

/home/workflows/workspace/packages/js/package.json
61:5 error The version specifier does not contain the installed version of "tinyglobby" package: 0.2.6 @nx/dependency-checks

[JamesHenry]

@benmccann The issue is that you haven't added tinyglobby to the root package.json

The repo doesn't (yet) use package manager workspaces, so your reference in the @nx/js package.json doesn't influence the installed packages in any way.

You can verify this with pnpm why:

❯ pnpm why tinyglobby                                                                                                                х 1 24s
Legend: production dependency, optional only, dev only

@nx/nx-source /Users/james/Repos/open-source/nrwl/nx-alt

devDependencies:
nuxt 3.13.2
├─┬ @nuxt/devtools 1.4.2
│ └── tinyglobby 0.2.6
└── tinyglobby 0.2.6

Right now the only way tinyglobby gets into the workspace is via a direct and transitive dependency from the nuxt package.

Therefore the fix is to run pnpm add tinyglobby@^0.2.10

[JamesHenry]

Thanks @benmccann, sorry I should have remembered this earlier:

Every time we make one of these kinds of PRs we should add a lint entry to prevent regressions:

nx/packages/js/.eslintrc.json

Line 8 in 5d61191

"no-restricted-imports": [

(It would be easy for a member of the team not familiar with this effort to add fast-glob back in again)

[JamesHenry]

FYI I made it a fix pre merge so it gets called out in the changelog

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.