Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): improve sync messages #29149

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Dec 2, 2024

nx sync:check (out of sync)

Before:
image

After:
image

The Custom out of sync message in these examples is a message returned from the sync generator, while the other one is the fallback message displayed if the sync generator doesn't return one.

nx sync:check (up to date)

Before:
image

After:
image

Running tasks

Before:
image

After:
image

Sync generator failures

Before:
image

After:
image

Sync generator failures (--verbose)

Before:
image

After:
image

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Dec 2, 2024
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 2:50pm

@leosvelperez leosvelperez force-pushed the core/improve-sync-messages branch from 18da202 to beffe43 Compare December 2, 2024 14:46
@leosvelperez leosvelperez requested a review from jaysoo December 2, 2024 14:47
@leosvelperez leosvelperez marked this pull request as ready for review December 2, 2024 14:47
@leosvelperez leosvelperez requested review from a team as code owners December 2, 2024 14:47
@leosvelperez leosvelperez merged commit e9be7d9 into master Dec 3, 2024
6 checks passed
@leosvelperez leosvelperez deleted the core/improve-sync-messages branch December 3, 2024 14:28
leosvelperez added a commit that referenced this pull request Dec 4, 2024
Update the npm workspaces tutorial to reflect the changes made in
#29149.

Updated doc:
https://nx-dev-git-docs-nx-sync-terminal-output-nrwl.vercel.app/getting-started/tutorials/npm-workspaces-tutorial

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
bcabanes pushed a commit that referenced this pull request Dec 5, 2024
Update the npm workspaces tutorial to reflect the changes made in
#29149.

Updated doc:
https://nx-dev-git-docs-nx-sync-terminal-output-nrwl.vercel.app/getting-started/tutorials/npm-workspaces-tutorial

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants