feat(rollup): use .cjs file extension for config files #29196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 012371f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
reviewed
Dec 4, 2024
packages/react/src/generators/library/lib/add-rollup-build-target.ts
Outdated
Show resolved
Hide resolved
packages/react/src/generators/library/lib/add-rollup-build-target.ts
Outdated
Show resolved
Hide resolved
jaysoo
force-pushed
the
feat/rollup-config-cjs
branch
from
dbd06ca to
ffff293
Compare
…get.ts Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
ndcunningham
approved these changes
Dec 4, 2024
jaysoo
force-pushed
the
feat/rollup-config-cjs
branch
from
7e328e5 to
34de59f
Compare
leosvelperez
approved these changes
Dec 4, 2024
Coly010
approved these changes
Dec 4, 2024
jaysoo
force-pushed
the
feat/rollup-config-cjs
branch
from
34de59f to
012371f
Compare
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rollup.config.jsfile will be resolved as ESM if the closestpackage.jsonhastype: 'module. This causes an error when computing the project graph and when reading the file for builds.This PR also updates the output directory to
{projectRoot}/distfor the new TS setup.Current Behavior
nx g @nx/react:lib --bundler=rolluphas an error due to Node resolutionExpected Behavior
nx g @nx/react:lib --bundler=rollupworks out of the boxRelated Issue(s)
Fixes #29193, #29195