fix(module-federation): ensure @nx/module-federation package is installed for users #29416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 4ef4c0d.
☁️ Nx Cloud last updated this comment at |
packages/angular/src/migrations/update-20-2-0/migrate-with-mf-import-to-new-package.ts
Show resolved
Hide resolved
Coly010
force-pushed
the
module-federation/force-install-package
branch
from
7f385c1 to
4ef4c0d
Compare
jaysoo
reviewed
Dec 19, 2024
| @@ -5,6 +5,12 @@ | |||
| "version": "20.2.0-beta.3", | |||
| "description": "Update the withModuleFederation import use @nx/module-federation/rspack.", | |||
| "factory": "./src/migrations/update-20-2-0/migrate-with-mf-import-to-new-package" | |||
| }, | |||
| "ensure-nx-module-federation-package": { | |||
There was a problem hiding this comment.
This is technically already handled by Angular and React plugins right? Is there a scenario where those aren't installed by Rspack is? We don't do this for Webpack.
There was a problem hiding this comment.
Each plugin is finding its own set of module-federation-dev-server executors to determine if MF projects exists.
I could combine the rspack ones into the react one, i just had them separated based on location of the executor
leosvelperez
approved these changes
Dec 19, 2024
jaysoo
approved these changes
Dec 19, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
…lled for users (#29416) ## Current Behavior The `@nx/module-federation` package is a direct dependency of some of the other packages in the Nx Plugin ecosystem. It should be resolved correctly by package managers such that it can be used when setting up MF projects. However, some users are facing issues with module resolutions where the package is not found as expected. ## Expected Behavior Install the package directly for the user to ensure module resolution works as expected. ## Related Issue(s) Fixes #29269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/module-federationpackage is a direct dependency of some of the other packages in the Nx Plugin ecosystem.It should be resolved correctly by package managers such that it can be used when setting up MF projects.
However, some users are facing issues with module resolutions where the package is not found as expected.
Expected Behavior
Install the package directly for the user to ensure module resolution works as expected.
Related Issue(s)
Fixes #29269