fix(angular): normalize name when forced to build selector #29417
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit feedd6c.
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
angular/library-generation
branch
from
50ad4ea to
97dcc4c
Compare
Coly010
force-pushed
the
angular/library-generation
branch
from
97dcc4c to
1a02ba9
Compare
Coly010
force-pushed
the
angular/library-generation
branch
from
1a02ba9 to
feedd6c
Compare
leosvelperez
approved these changes
Dec 19, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
## Current Behavior When passing a project name with a `/` in it to the library generator, this name passes through to the `component` generator. The `component` generator may then attempt to build a selector from this name, however, it does not normalize the `/`. ## Expected Behavior Ensure the `/` is normalized from the name when building the selector ## Related Issue(s) Fixes #29229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When passing a project name with a
/in it to the library generator, this name passes through to thecomponentgenerator.The
componentgenerator may then attempt to build a selector from this name, however, it does not normalize the/.Expected Behavior
Ensure the
/is normalized from the name when building the selectorRelated Issue(s)
Fixes #29229