Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): generateFiles should rename paths recursively #4784

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Feb 12, 2021

Current Behavior

generateFiles does not rename all instances in file path.

Expected Behavior

generateFiles does rename all instances in file path.

Related Issue(s)

Fixes #4649

@beeman beeman force-pushed the beeman/recursive-generate-files branch from c8dc4c2 to 55afe0f Compare February 12, 2021 19:57
@beeman beeman force-pushed the beeman/recursive-generate-files branch from 55afe0f to fc11303 Compare February 12, 2021 20:08
@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2021

Nx Cloud Report

CI ran the following commands for commit fc11303. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 2/12/2021, 8:10:54 PM
#000000 nx run-many --target=e2e --projects=e2e-angular 2/12/2021, 8:13:01 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest 2/12/2021, 8:12:10 PM
#000000 nx run-many --target=e2e --projects=e2e-next,e2e-gatsby 2/12/2021, 8:12:08 PM
#000000 nx run-many --target=e2e --projects=e2e-node 2/12/2021, 8:12:09 PM
#000000 nx run-many --target=e2e --projects=e2e-nx-plugin 2/12/2021, 8:12:19 PM
#000000 nx run-many --target=e2e --projects=e2e-react 2/12/2021, 8:12:11 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 2/12/2021, 8:12:12 PM
#000000 nx run-many --target=e2e --projects=e2e-workspace 2/12/2021, 8:12:11 PM
#000000 nx run-many --target=lint --all --parallel 2/12/2021, 8:16:38 PM
#000000 nx run-many --target=test --all --parallel 2/12/2021, 8:11:23 PM

Sent with 💌 from NxCloud.

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

This LGTM! 🎉

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[workspace-generator] the generateFiles command only renames files 1 level deep
2 participants