fix(angular): check for root tslint.json before updating to support ESlint #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit f767abe. Click to see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
ng add @nrwl/workspaceon an Angular CLI workspace with no roottslint.jsonfails. This file would not exist in a workspace using ESlint, such as https://github.com/tomastrajan/angular-ngrx-material-starterExpected Behavior
Running
ng add @nrwl/workspaceon an Angular CLI workspace with no roottslint.jsoncontinues to run.Related Issue(s)
Fixes #4761