fix(node): assets should be copied when building with --watch #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/Gbt1xSi4MrW1XWN2zzDo3aK4GSAL [Deployment for ee5138e canceled] |
Nx Cloud ReportCI ran the following commands for commit ee5138e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/node-watch-mode-assets
branch
from
b83f6e1 to
c95f246
Compare
AgentEnder
force-pushed
the
fix/node-watch-mode-assets
branch
from
c95f246 to
a285840
Compare
AgentEnder
force-pushed
the
fix/node-watch-mode-assets
branch
from
a285840 to
0cc5915
Compare
AgentEnder
force-pushed
the
fix/node-watch-mode-assets
branch
from
0cc5915 to
067c989
Compare
FrozenPandaz
requested changes
Jun 4, 2021
AgentEnder
force-pushed
the
fix/node-watch-mode-assets
branch
from
067c989 to
cf0fdd3
Compare
AgentEnder
force-pushed
the
fix/node-watch-mode-assets
branch
from
cf0fdd3 to
4742736
Compare
FrozenPandaz
force-pushed
the
fix/node-watch-mode-assets
branch
from
4742736 to
ee5138e
Compare
philipjfulcher
pushed a commit
to dapperdandev/nx
that referenced
this pull request
Jul 10, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Assets are not copied to dist when running
nx build my-node-lib --watch.Expected Behavior
Assets, including package.json, should be present in dist.
Caveats
This change does not add the assets to the watcher, since it is using the typescript compiler's watch program. As such, if assets change it does not retrigger the compiler.
Related Issue(s)
Fixes #5724