[CI][BUGFIX] Suppress runtime output so that github action doesn't hang

nseymoursmith · Nov 20, 2023 · 0a0747f · 0a0747f
1 parent e7426b7
commit 0a0747f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -3,7 +3,8 @@ run-name: Deploy to DigitalOcean by @${{ github.actor }}
 on:
   push:
     branches:
-      - main, fix-ci
+      - main
+      - fix-ci
 
 jobs:
   deploy:
@@ -36,3 +37,4 @@ jobs:
              fi
 
              echo 'Deployment successful to digital ocean'
+             exit 0
diff --git a/deploy-rust.sh b/deploy-rust.sh
@@ -14,11 +14,11 @@ if [ $? != 0 ]; then
     exit 1
 fi
 
-./target/release/api-example &
+# If you don't pipe stderr/out to null then github's CI will never exit!
+./target/release/api-example > /dev/null 2>&1 &
 
 # Capture PID of last executed command with `$!`
 # and use it to generate a kill script
 echo "kill $!" > ../stop-api.sh
 
 chmod +x ../stop-api.sh
-exit 0
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,7 +3,8 @@ run-name: Deploy to DigitalOcean by @${{ github.actor }} @@
     on:
       push:
         branches:
-          - main, fix-ci
+          - main
+          - fix-ci
     jobs:
       deploy:
@@ Expand Down Expand Up / @@ -36,3 +37,4 @@ jobs: @@
                  fi
                  echo 'Deployment successful to digital ocean'
+                 exit 0