Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #332 and #334 #335

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Fixes #332 and #334 #335

merged 1 commit into from
Mar 10, 2016

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Mar 10, 2016

No description provided.

@nhooyr nhooyr mentioned this pull request Mar 10, 2016
Closed
@nsf
Copy link
Owner

nsf commented Mar 10, 2016

Well, whatever. I really don't like ToSlash usage. But I have no time fixing that stuff myself, so I'll pull it.

@nsf nsf merged commit 0d7e252 into nsf:master Mar 10, 2016
@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 10, 2016

@nsf thing is, g_daemon.context.SrcDirs() uses filepath so we have to use filepath.ToSlash to convert after. Also I made a small mistake, the call to ToSlash should be before we convert the SrcPath to the PkgPath. the file package depends on the separator being a /.

@nsf
Copy link
Owner

nsf commented Mar 10, 2016

Pulled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhooyr @nsf