interop: add keccak256 implementation #3301

AliceInHunterland · 2024-01-25T13:33:05Z

roman-khimov · 2024-01-25T14:18:18Z

Should be a draft, we're not merging it before C# 3.7.

AliceInHunterland · 2024-01-25T14:33:45Z

problems with TestKeccak256_Compat

AnnaShaleva

Just for the record: once PR is finished and ready to be merged, we need to update interop deps and move it under Cockatrice hardfork. Depends on #3213.

pkg/core/native/crypto.go

pkg/core/native/crypto_test.go

pkg/interop/native/crypto/crypto.go

pkg/core/native/crypto.go

pkg/interop/native/crypto/crypto.go

pkg/core/native/crypto_test.go

codecov · 2024-02-08T12:54:04Z

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.88%. Comparing base (fa1c07e) to head (c090628).

Files	Patch %	Lines
pkg/core/native/crypto.go	84.61%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
+ Coverage   84.80%   84.88%   +0.07%     
==========================================
  Files         331      331              
  Lines       44969    44982      +13     
==========================================
+ Hits        38138    38183      +45     
+ Misses       5318     5284      -34     
- Partials     1513     1515       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnnaShaleva

Need to update interop deps one more time after PR is about to be merged to master.

pkg/core/native/crypto_test.go

pkg/core/native/native_test/cryptolib_test.go

AnnaShaleva

Otherwise LGTM, will keep this until some real proximity to v3.7.0.

AnnaShaleva · 2024-02-09T14:08:14Z

pkg/interop/native/crypto/crypto.go

@@ -92,3 +92,8 @@ func Bls12381Mul(x Bls12381Point, mul []byte, neg bool) Bls12381Point {
 func Bls12381Pairing(g1, g2 Bls12381Point) Bls12381Point {
 	return neogointernal.CallWithToken(Hash, "bls12381Pairing", int(contract.NoneFlag), g1, g2).(Bls12381Point)
 }
+
+// Keccak256 calls `keccak256` method of native CryptoLib contract and computes Keccak256 hash of b.


Preserve the line width.

AnnaShaleva · 2024-03-18T16:40:41Z

@AliceInHunterland, please, rebase this PR onto fresh master and update go.mod files in a separate commit. We'll merge this PR after update, 3.7 is coming.

AnnaShaleva · 2024-03-21T16:34:18Z

@AliceInHunterland, tests are failing. Please, convert from draft when ready.

AnnaShaleva · 2024-03-21T16:36:14Z

It's block 20 stateroot hash, please, rebase onto fresh master:

24-03-20T09:58:55.3392468Z     logger.go:146: 2024-03-20T09:57:57.516Z	DEBUG	processing rpc request	{"method": "getnativecontracts", "params": "[]"}
2024-03-20T09:58:55.3393760Z     logger.go:146: 2024-03-20T09:57:57.523Z	DEBUG	processing rpc request	{"method": "findstoragehistoric", "params": "[858c873539d6d24a70f2be13f9dafc61aef2b63c2aa16bb440676de6e44e3cf1 565cff9508ebc75aadd7fe59f38dac610ab6093c YWE=]"}
2024-03-20T09:58:55.3395532Z     logger.go:146: 2024-03-20T09:57:57.523Z	INFO	Error encountered with rpc request	{"code": -102, "cause": "Failed to get historical contract state: item not found", "method": "findstoragehistoric", "params": "[858c873539d6d24a70f2be13f9dafc61aef2b63c2aa16bb440676de6e44e3cf1 565cff9508ebc75aadd7fe59f38dac610ab6093c YWE=]"}
2024-03-20T09:58:55.3395746Z     client_test.go:2350: 
2024-03-20T09:58:55.3396329Z         	Error Trace:	/home/runner/work/neo-go/neo-go/pkg/services/rpcsrv/client_test.go:2350
2024-03-20T09:58:55.3396548Z         	Error:      	Received unexpected error:
2024-03-20T09:58:55.3397297Z         	            	Unknown contract (-102) - Failed to get historical contract state: item not found
2024-03-20T09:58:55.3397540Z         	Test:       	TestClient_FindStorageHistoric
2024-03-20T09:58:55.3398082Z     logger.go:146: 2024-03-20T09:57:57.523Z	INFO	shutting down RPC server	{"endpoint": "127.0.0.1:34691"}
2024-03-20T09:58:55.3398863Z     logger.go:146: 2024-03-20T09:57:57.524Z	INFO	persisted to disk	{"blocks": 23, "keys": 1265, "headerHeight": 23, "blockHeight": 23, "took": "473.497µs"}
2024-03-20T09:58:55.3399074Z --- FAIL: TestClient_FindStorageHistoric (0.07s)

AnnaShaleva · 2024-03-22T12:40:24Z

@AliceInHunterland, ditto, block 20 stateroot from RPC tests needs to be updated because you change native Management's state by adding new method to native CryptoLib's manifest.

Port neo-project/neo#2925. Close #3295 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>

AliceInHunterland requested review from AnnaShaleva and roman-khimov as code owners January 25, 2024 13:33

AliceInHunterland marked this pull request as draft January 25, 2024 14:21

AliceInHunterland force-pushed the keccak256 branch from 0742083 to 61e42d4 Compare January 25, 2024 14:32

AnnaShaleva reviewed Jan 26, 2024

View reviewed changes

AliceInHunterland force-pushed the keccak256 branch from 61e42d4 to 8261620 Compare January 26, 2024 15:55

AnnaShaleva reviewed Feb 6, 2024

View reviewed changes

pkg/core/native/crypto.go Outdated Show resolved Hide resolved

pkg/interop/native/crypto/crypto.go Show resolved Hide resolved

pkg/core/native/crypto_test.go Outdated Show resolved Hide resolved

pkg/core/native/crypto_test.go Outdated Show resolved Hide resolved

AliceInHunterland force-pushed the keccak256 branch 3 times, most recently from 26e9aba to b64725c Compare February 8, 2024 12:48

AnnaShaleva reviewed Feb 8, 2024

View reviewed changes

AliceInHunterland force-pushed the keccak256 branch from b64725c to 116d180 Compare February 9, 2024 08:13

AliceInHunterland requested a review from AnnaShaleva February 9, 2024 08:14

AnnaShaleva reviewed Feb 9, 2024

View reviewed changes

AliceInHunterland force-pushed the keccak256 branch from 116d180 to e7450ca Compare February 9, 2024 14:22

AliceInHunterland force-pushed the keccak256 branch 2 times, most recently from 49c6658 to ac0bf94 Compare March 20, 2024 09:17

AliceInHunterland requested a review from AnnaShaleva March 20, 2024 09:17

AliceInHunterland force-pushed the keccak256 branch from ac0bf94 to 55589fa Compare March 20, 2024 09:53

interop: add keccak256 implementation

1840c05

Port neo-project/neo#2925. Close #3295 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>

AliceInHunterland force-pushed the keccak256 branch from 55589fa to 1840c05 Compare March 22, 2024 14:16

AliceInHunterland added 2 commits March 22, 2024 17:17

*: update interop deps

6d1a22d

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>

rpcsrv: update block20StateRootLE

c090628

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>

AliceInHunterland marked this pull request as ready for review March 22, 2024 14:20

AnnaShaleva approved these changes Mar 23, 2024

View reviewed changes

AnnaShaleva merged commit 37d7a3a into master Mar 23, 2024
19 of 20 checks passed

AnnaShaleva deleted the keccak256 branch March 23, 2024 11:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

interop: add keccak256 implementation #3301

interop: add keccak256 implementation #3301

AliceInHunterland commented Jan 25, 2024

roman-khimov commented Jan 25, 2024

AliceInHunterland commented Jan 25, 2024

AnnaShaleva left a comment

codecov bot commented Feb 8, 2024 •

edited

Loading

AnnaShaleva left a comment

AnnaShaleva left a comment

AnnaShaleva Feb 9, 2024

AnnaShaleva commented Mar 18, 2024

AnnaShaleva commented Mar 21, 2024

AnnaShaleva commented Mar 21, 2024

AnnaShaleva commented Mar 22, 2024

interop: add keccak256 implementation #3301

interop: add keccak256 implementation #3301

Conversation

AliceInHunterland commented Jan 25, 2024

roman-khimov commented Jan 25, 2024

AliceInHunterland commented Jan 25, 2024

AnnaShaleva left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 8, 2024 • edited Loading

Codecov Report

AnnaShaleva left a comment

Choose a reason for hiding this comment

AnnaShaleva left a comment

Choose a reason for hiding this comment

AnnaShaleva Feb 9, 2024

Choose a reason for hiding this comment

AnnaShaleva commented Mar 18, 2024

AnnaShaleva commented Mar 21, 2024

AnnaShaleva commented Mar 21, 2024

AnnaShaleva commented Mar 22, 2024

codecov bot commented Feb 8, 2024 •

edited

Loading