ir,storage: Make healthcheck output visible in docker inspect
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Healthcheck commands of `ir` and `storage` service containers execute
`neofs-cli control healthcheck`. Previously, exec results were just
grep-ed. If output didn't contain particular string, health state log
exit code was 1 with empty output. This did not allow to find out what
exactly was output by the command. To make it easier to detect problems,
the output should be stored regardless of the return code.
```
$ docker inspect --format "{{json .State.Health }}" s01 | jq
```
Before:
```json
{
"Status": "unhealthy",
"FailingStreak": 1,
"Log": [
{
"Start": "2023-08-08T12:14:31.525815071+04:00",
"End": "2023-08-08T12:14:33.074067267+04:00",
"ExitCode": 1,
"Output": ""
}
]
}
```
Now:
```json
{
"Status": "unhealthy",
"FailingStreak": 1,
"Log": [
{
"Start": "2023-08-08T12:14:31.525815071+04:00",
"End": "2023-08-08T12:14:33.074067267+04:00",
"ExitCode": 1,
"Output": "Network status: OFFLINE\nHealth status: STARTING\n"
}
]
}
```
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
|
I think it's irrelevant now with #272 merged. |
|
So closing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Healthcheck commands of
irandstorageservice containers executeneofs-cli control healthcheck. Previously, exec results were just grep-ed. If output didn't contain particular string, health state log exit code was 1 with empty output. This did not allow to find out what exactly was output by the command. To make it easier to detect problems, the output should be stored regardless of the return code.Before:
{ "Status": "unhealthy", "FailingStreak": 1, "Log": [ { "Start": "2023-08-08T12:14:31.525815071+04:00", "End": "2023-08-08T12:14:33.074067267+04:00", "ExitCode": 1, "Output": "" } ] }Now:
{ "Status": "unhealthy", "FailingStreak": 1, "Log": [ { "Start": "2023-08-08T12:14:31.525815071+04:00", "End": "2023-08-08T12:14:33.074067267+04:00", "ExitCode": 1, "Output": "Network status: OFFLINE\nHealth status: STARTING\n" } ] }