Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping buttons on Android 5.1.1 #41

Closed
awinterstale33 opened this issue Apr 12, 2016 · 23 comments
Closed

Overlapping buttons on Android 5.1.1 #41

awinterstale33 opened this issue Apr 12, 2016 · 23 comments
Labels
bug os:Android

Comments

@awinterstale33
Copy link

Are the del and ctrl buttons supposed to be covered up for now? I have a Galaxy Note 4 on Android 5.1.1.
screenshot_2016-04-07-16-44-52
@Vogtinator
Copy link
Member

Definitely not! Except for the two misbehaving columns the layout looks fine though, so I don't know what went wrong here. The keypad layout was changed now to include key labels as well, those changes might have fixed this issue (Vogtinator/firebird#36).
I'll upload an .apk later.

@adriweb adriweb added the bug label Apr 14, 2016
@awinterstale33
Copy link
Author

Thank you! Will you post something or should I just periodically check in?
On Apr 12, 2016 12:04 AM, "Fabian Vogt" notifications@github.com wrote:

Definitely not! Except for the two misbehaving columns the layout looks
fine though, so I don't know what went wrong here. The keypad layout was
changed now to include key labels as well, those changes might have fixed
this issue (Vogtinator/firebird#36
Vogtinator/firebird#36).
I'll upload an .apk later.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#41 (comment)

@Vogtinator
Copy link
Member

Sorry, I haven't got around to upload the .apk yet, I'll do it today.

@Vogtinator
Copy link
Member

Try this: It contains an unfinished button label rework, so some keys look odd.
QtApp-debug.apk.zip

@awinterstale33
Copy link
Author

Well it definitely is an improvement! I wonder why my phone is making it
looking like that? It looks fine on my LG gpad 7.
On Apr 18, 2016 9:26 AM, "Fabian Vogt" notifications@github.com wrote:

Try this: It contains an unfinished button label rework, so some keys look
odd.
QtApp-debug.apk.zip
https://github.com/nspire-emus/firebird/files/224214/QtApp-debug.apk.zip

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#41 (comment)

@adriweb
Copy link
Member

adriweb commented Apr 19, 2016 •
edited
Loading

So you're seeing the new button labels correctly...
but there is still some weird overlap? :o

@awinterstale33
Copy link
Author

screenshot_2016-04-18-18-35-01
Sorry, I didn't know attaching a picture to the email didn't show up on the site.

@NikBarbour
Copy link

Hi - great emulator, thanks for sharing it.
I can confirm this bug, I think it's a Samsung Note 4 issue as I'm also using an Samsung Note 4 SM-N910F running LP5.0.1

The 6 buttons (3 each side) which should be either side of the direction pad, spill over onto the number section of the keyboard same as in the pics in this post.
Also 2nd function definitions don't display.
Tried the test.apk posted in this thread, and whilst better than the beta build 3 build appearance wise, it crashes constantly and was unusable.

Thanks again for sharing.
No idea how to add pics using mobile device here. Sorry.

@Vogtinator
Copy link
Member

Hi,
here's a (completely untested) build with the latest Qt 5.7.0. Maybe it solves some of your issues:
QtApp-debug.apk.zip

Tried the test.apk posted in this thread, and whilst better than the beta build 3 build appearance wise, it crashes constantly and was unusable.

Can you provide some stack backtraces from the ADB log?

@NikBarbour
Copy link

I don't have root access on this device as it's employer provided, but I do beta testing on another app (Aerofly2) which was crashing regularly. I found this article...
Article to add logcat file in download folder on un-rooted device.
http://stackoverflow.com/questions/25765366/android-logcat-send-log-entries-from-device-using-email
By adding this code as indicated this allowed logcat files to be obtained from a non rooted device. It solved their issues, I'm just suggesting this incase it helps here.
Apologies for my complete lack of technical knowledge.
Beta build 3 looks awesome on my Shield K1, with perfect button alignment BTW. It seems to be a Note 4 issue only.
Great emulator. Much appreciated.
I'll report back on the build provided.

@NikBarbour
Copy link

Just tried out the QtApp-Debug.apk.zip build you provided. Thanks again.
The 2nd functions are more visible, but unfortunately the 6 keys, 3 each side of the direction pad still overlap the keyboard below on the Note4.
See pic via Google drive link below...
https://drive.google.com/file/d/0B6PTQr6lCNNneWZtX3RxUDc1SkU/view?usp=drivesdk
Unfortunately the build also constantly crashes again on start of emulation, whearas beta build 3 is stable with my flash image (cx cas 4.2.0).

Thanks again for your help here though.
I'm happy to use it via my Shield K1 which works really well with build 3. Happy to test anything that helps you out though.

@Bwachtel
Copy link

I know I'm late to this party, but I just found out about this project yesterday. I was able to get it up and running on my note 7 running 6.0.1. But I have the same issue where the buttons overlap (looks exactly like original post). Also the new layout you provided in this thread is not in the current release? I'm guess this project is abandoned, but I hope not because I think this is a brilliant idea and the emulator is. Very professionally done!

Thanks
Bwachtel

@Vogtinator
Copy link
Member

I'm guess this project is abandoned, but I hope not

It's not abandoned at all, in fact I'm currently planning a major UI redesign with a UI that works on mobile as well as on desktop devices.

because I think this is a brilliant idea and the emulator is. Very professionally done!

Thanks!

@NikBarbour
Copy link

NikBarbour commented Sep 29, 2016 •
edited by adriweb
Loading

It's much appreciated and useful to me to.
I use this and also the HP Prime calc app on my phone a lot for work (mech
eng) . A ui revamp would be awesome though.

Thanks for your work on this.

@Bwachtel
Copy link

I stand corrected! I look forward to the new update! Any ETA on it so I know when to look back? No rush, just excited to try it out :)

@Vogtinator
Copy link
Member

Here is a test build with HiDPI scaling disabled. I have literally no idea whether this could work, it might even make everything worse.

QtApp-debug.zip

@adriweb
Copy link
Member

adriweb commented Nov 26, 2016

A new version has been released: https://github.com/nspire-emus/firebird/releases/latest
Please try it and see if that fixes the problem(s).

Please close the issue if it's fixed.

@NikBarbour
Copy link

NikBarbour commented Nov 26, 2016 via email

@ghost
Copy link

ghost commented Mar 6, 2018

I also have the overlapping buttons, both in portrait and landscape. Also, is there a way to disable the splash screen so that the calculator opens faster?

ZTE Axon 7
Android 7.1.1
Firebird 1.4

https://drive.google.com/file/d/1Z0CBa_kUdmfliH-cf1t05mwMutsd1ApJ/view?usp=drivesdk

https://drive.google.com/file/d/1fb5F-xNw8vMCgVQK6cgonG9y49tuFPfk/view?usp=drivesdk

@Vogtinator
Copy link
Member

The splashscreen is only shown while it's loading, if you disable it you'll have a black screen for the same period of time.

@Vogtinator
Copy link
Member

Here's a build with some of the latest changes - some warnings related to layouting the keypad got fixed, so maybe this issue does not exist anymore. Please try:

firebird.zip

@ghost
Copy link

ghost commented Jun 26, 2018

Problem is still there (buttons still overlap). I never noticed before, but it also opens the settings pane when the screen autorotates (both versions, 1.4 and 1.4-beta).

@Vogtinator Vogtinator mentioned this issue Mar 15, 2019
Closed
Vogtinator added a commit to Vogtinator/firebird-fork that referenced this issue Oct 20, 2022
@Vogtinator
Fix spacing of top buttons with enabled scaling (nspire-emus#41)
22488bd 
The ColumnLayout which manages the buttons next to the touchpad has a default
minimum spacing of 5, which is even affected by the scale factor. The keypad
has its own scaling based on the available space, so just ignore that.
@Vogtinator Vogtinator mentioned this issue Oct 20, 2022
Merged
Vogtinator added a commit that referenced this issue Oct 22, 2022
@Vogtinator
Fix spacing of top buttons with enabled scaling (#41)
0be770a 
The ColumnLayout which manages the buttons next to the touchpad has a default
minimum spacing of 5, which is even affected by the scale factor. The keypad
has its own scaling based on the available space, so just ignore that.
@Vogtinator
Copy link
Member

Fixed with #275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os:Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@adriweb @Vogtinator @awinterstale33 @NikBarbour @Bwachtel