Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polish translation #207

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Add Polish translation #207

merged 6 commits into from
Jun 24, 2020

Conversation

Atrate
Copy link
Contributor

@Atrate Atrate commented Jun 24, 2020

Changes:

  • Added Polish translation
  • Capitalized "Firebird" where appropriate

Signed-off-by: Atrate Atrate@protonmail.com

Signed-off-by: Atrate <Atrate@protonmail.com>
Signed-off-by: Atrate <Atrate@protonmail.com>
@Vogtinator
Copy link
Member

Thanks! Please run lrelease i18n/pl_PL.ts and add i18n/pl_PL.qm to resources.qrc.

Or if you'd like to do some cleanup, try CONFIG += lrelease embed_translations in firebird.pro, which might need some adjustments elsewhere.

Signed-off-by: Atrate <Atrate@protonmail.com>
Signed-off-by: Atrate <Atrate@protonmail.com>
Signed-off-by: Atrate <Atrate@protonmail.com>
@Atrate
Copy link
Contributor Author

Atrate commented Jun 24, 2020

Done, @Vogtinator

@Vogtinator
Copy link
Member

Looks like you did both now - with the added CONFIG values the .qm files can be dropped from the repo and resources.qrc.
If that works (you might have to adjust the path in main.cpp and mainwindow.cpp), you can do that.
Or undo the CONFIG change, as otherwise it looks good now.

@Atrate
Copy link
Contributor Author

Atrate commented Jun 24, 2020

Alright, it's simpler to just remove the config override. Done.

@Vogtinator
Copy link
Member

I gave it a quick try and noticed that the dock window titles aren't translated. That's most likely a bug in the code though and not related to this translation, as the other languages are also affected.

Thanks for the contribution!

@Vogtinator Vogtinator merged commit 57dfbbe into nspire-emus:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants