-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow for Android #285
Conversation
Vogtinator
commented
Dec 4, 2022
•
edited
Loading
edited
- Test the built apk
- Check how it is currently signed, maybe add a custom key
The APK works fine here. As expected, updating from a previous build was not possible because the signer differs, so I had to remove the old one first. |
56c5bb7
to
f422b01
Compare
6fbf054
to
b4c944d
Compare
Custom key added. When available (builds from commits in this repo), the APK will be signed with that key. The annoying part is that upgrades are not possible if the signer differs. Without upgrades, it's necessary to uninstall the app completely and install the new apk, which means that all settings will be lost. The key will (probably? hopefully?) be different between specific GH action runs unless it's done in this repo with the FB key. It'll also differ between my local builds with my local key and builds from GH actions in this repo. I'm not sure what the best design here is. Is the .apk meant for actual use or just testing? If it's for actual use then the key should not be used for singing PR builds but just releases. Even if it's just testing, it would be very useful to be able to seamlessly switch between builds from different PRs. I think at least for now I'll keep building and signing the APKs for releases manually, maybe also for PRs for testing. Otherwise all users would have to uninstall the app once :-( (On top of that I also don't really like the trust model of GH builds) |
If ANDROID_KEYSTORE and ANDROID_KEYSTORE_PWD secrets are available, the apk will be signed using those. This is necessary to allow upgrading between subsequent builds in the same repo.
With the new APK,
|
... which is apparently a bug in my local apksigner from the 28.0.3 build-tools. Meh. |
b4c944d
to
5bfa749
Compare
Tested on my phone, subsequent builds from this PR can be installed without losing configuration. |