ABS add support for using a Service principle via EnvCreds #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSeal
approved these changes
Nov 1, 2023
|
Thanks for the addition! Will get it into this next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows abs:// to be used without a sas token. In this case it will fall back on Azure identities Environment credentials. This allows you to use a service principle for authentication with azure.
Changes:
abs.py changed the regex
abs.py added a default for when sas token is empty. It will use env creds in this case.
tests for ABS without a sas token
Dependecies:
azure-identity -- because we will be using EnvironmentCredential from it