Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stale config #757

Merged
merged 3 commits into from
Nov 21, 2023
Merged

add stale config #757

merged 3 commits into from
Nov 21, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 21, 2023

What does this PR do?

There are tens of idle issues so it would be good to have them resolved or closed as likely the issue was resolved but not reported back... but this is just a suggestion, would like to hear from you what you think 🐰

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #757 (99e35d9) into main (7d8d8ae) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          17       17           
  Lines        1622     1622           
=======================================
  Hits         1484     1484           
  Misses        138      138           

Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm good with this bot being added. Let's make sure that the timeline makes sense for @MSeal.

.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
.github/stale.yml Outdated Show resolved Hide resolved
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@Borda Borda requested review from willingc and MSeal November 21, 2023 12:52
@Borda
Copy link
Member Author

Borda commented Nov 21, 2023

In general, I'm good with this bot being added.

maybe we can set even more relaxed delays, but I gues 1 year is long one :)

Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge. @MSeal If we want to adjust timing, we can do in a separate PR. Thanks @Borda. 🎉

@willingc willingc enabled auto-merge (squash) November 21, 2023 13:19
@Borda
Copy link
Member Author

Borda commented Nov 21, 2023

I'm going to approve and merge

There are also 30 days for PR and 60 days for issues before anything practically happen (meaning being eventually closed)

@willingc willingc merged commit b9b43bf into main Nov 21, 2023
14 checks passed
@willingc willingc deleted the stale branch November 21, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants