-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: specify platform linux/amd64 in Dockerfile #161
base: main
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for nautilus-wallet canceled. 🔨 Explore the source changes: 452ca71 🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/623065a89e5b4e0009a09153 |
✔️ Deploy Preview for affectionate-mirzakhani-7a7e75 canceled. 🔨 Explore the source changes: 452ca71 🔍 Inspect the deploy log: https://app.netlify.com/sites/affectionate-mirzakhani-7a7e75/deploys/623065a8cdcc190008773d21 |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 42.37% 42.37%
=======================================
Files 201 201
Lines 3507 3507
Branches 687 687
=======================================
Hits 1486 1486
Misses 2021 2021 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
(I tweaked the PR title to reflect the change a bit more explicitly, for the merge commit message.) |
Docker images built with Apple Silicon (or another ARM64 based architecture) can create issues when deploying the images to a Linux or Windows-based AMD64 environment. Therefore, you need a way to build AMD64 based images on the ARM64 architecture, whether it's using Docker build (for individual images) or docker-compose build (e.g. for multi-image apps running in a docker-compose network)
452ca71
to
41a3463
Compare
✅ Deploy Preview for nautilus-wallet-staging canceled.
|
Docker images built with Apple Silicon (or another ARM64 based architecture) can create issues when deploying the images to a Linux or Windows-based AMD64 environment. Therefore, you need a way to build AMD64 based images on the ARM64 architecture, whether it's using Docker build (for individual images) or docker-compose build (e.g. for multi-image apps running in a docker-compose network)