Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify platform linux/amd64 in Dockerfile #161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Brianspha
Copy link
Contributor

Docker images built with Apple Silicon (or another ARM64 based architecture) can create issues when deploying the images to a Linux or Windows-based AMD64 environment. Therefore, you need a way to build AMD64 based images on the ARM64 architecture, whether it's using Docker build (for individual images) or docker-compose build (e.g. for multi-image apps running in a docker-compose network)

@netlify
Copy link

netlify bot commented Mar 15, 2022

✔️ Deploy Preview for nautilus-wallet canceled.

🔨 Explore the source changes: 452ca71

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/623065a89e5b4e0009a09153

@netlify
Copy link

netlify bot commented Mar 15, 2022

✔️ Deploy Preview for affectionate-mirzakhani-7a7e75 canceled.

🔨 Explore the source changes: 452ca71

🔍 Inspect the deploy log: https://app.netlify.com/sites/affectionate-mirzakhani-7a7e75/deploys/623065a8cdcc190008773d21

web-server/Dockerfile Outdated Show resolved Hide resolved
web-server/docker-compose.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #161 (41a3463) into main (1427287) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   42.37%   42.37%           
=======================================
  Files         201      201           
  Lines        3507     3507           
  Branches      687      687           
=======================================
  Hits         1486     1486           
  Misses       2021     2021           

Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@PiDelport PiDelport changed the title feat: Dockerfile update Apple Silicon feat: specify platform linux/amd64 in Dockerfile Mar 16, 2022
@PiDelport
Copy link
Collaborator

(I tweaked the PR title to reflect the change a bit more explicitly, for the merge commit message.)

Docker images built with Apple Silicon (or another ARM64 based architecture) can create issues when deploying the images to a Linux or Windows-based AMD64 environment. Therefore, you need a way to build AMD64 based images on the ARM64 architecture, whether it's using Docker build (for individual images) or docker-compose build (e.g. for multi-image apps running in a docker-compose network)
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for nautilus-wallet-staging canceled.

Name Link
🔨 Latest commit 41a3463
🔍 Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/650970e48f15c20008ec5f14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants