Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate #22

Merged
merged 6 commits into from
Jul 21, 2021
Merged

translate #22

merged 6 commits into from
Jul 21, 2021

Conversation

jongbonga
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 15, 2021 •
edited
Loading

✔️ Deploy Preview for nautilus-wallet ready!

🔨 Explore the source changes: 357afc9

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/60f889d90a623d0007c3669a

😎 Browse the preview: https://deploy-preview-22--nautilus-wallet.netlify.app/

@codecov
Copy link

codecov bot commented Jul 15, 2021 •
edited
Loading

Codecov Report

Merging #22 (357afc9) into main (2b032bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines           24        24           
=========================================
  Hits            24        24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b032bf...357afc9. Read the comment docs.

@jongbonga jongbonga self-assigned this Jul 18, 2021
@jongbonga jongbonga requested review from longtomjr and PiDelport July 18, 2021 11:46
@jongbonga jongbonga added the M: web-client Module: Web client app (Angular) label Jul 21, 2021
@jongbonga jongbonga merged commit 27355d7 into main Jul 21, 2021
@PiDelport
Copy link
Collaborator

PiDelport commented Jul 22, 2021 •
edited
Loading

Note: It looks like the 357afc9 merge actually rolled back the required package-lock.json changes.

I'm not sure why npm ci didn't catch that: it's supposed to.

@PiDelport
Copy link
Collaborator

It looks like that's actually a npm ci bug / regression:

PiDelport added a commit that referenced this pull request Jul 22, 2021
@PiDelport
chore(web-client): update package-lock.json (missed in PR #22)
38e500b 
See comment:

*
#22 (comment)
@PiDelport PiDelport mentioned this pull request Jul 22, 2021
Merged
PiDelport added a commit that referenced this pull request Jul 22, 2021
@PiDelport
translate 2 (#32)
7e23c77 
* chore(web-client): update package-lock.json (missed in PR #22)

See comment: #22 (comment)

* feat(web-client, TranslocoRootModule): use getBrowserLang for defaultLang, with fallback to 'en'

* chore(web-client, storybook): import TranslocoRootModule

(TranslocoRootModule requires HttpClientModule)
@PiDelport PiDelport mentioned this pull request Jul 22, 2021
Merged
@ntls-io ntls-io deleted a comment from jongbonga Jul 22, 2021
@PiDelport PiDelport deleted the translate branch October 29, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiDelport PiDelport PiDelport approved these changes

@longtomjr longtomjr Awaiting requested review from longtomjr

Assignees

@jongbonga jongbonga

Labels
M: web-client Module: Web client app (Angular)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jongbonga @PiDelport