Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

feat(rtc_types): more enclave message work for set_access_key #105

Merged
merged 6 commits into from
Jun 21, 2021
Merged

feat(rtc_types): more enclave message work for set_access_key #105

merged 6 commits into from
Jun 21, 2021

Conversation

PiDelport
Copy link
Collaborator

@PiDelport PiDelport commented Jun 18, 2021 •
edited
Loading

This adds set_access_key::SetAccessKeyResult, and makes SealingError FFI-compatible.

Precedes PR #87

@PiDelport PiDelport added the M: types lib Module: Types library (rtc_types) label Jun 18, 2021
@PiDelport PiDelport self-assigned this Jun 18, 2021
@PiDelport PiDelport marked this pull request as draft June 18, 2021 20:19
@PiDelport PiDelport mentioned this pull request Jun 18, 2021
Draft
7 tasks
@PiDelport
Copy link
Collaborator Author

Note: This is actually ready for review, and doesn't actually depend on PR #104, so #104 and #105 could be reviewed and merged in any order: they're just stacked in sequence currently to ease PR #87.

longtomjr
longtomjr approved these changes Jun 20, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you just expand on the reason for renaming the C bindings (maybe add a comment in the build file)

@PiDelport PiDelport force-pushed the feat-more-enclave-messages branch from b4740d3 to 67b48ac Compare June 21, 2021 10:09
@PiDelport PiDelport changed the base branch from feat-with-acquired-sessions to main June 21, 2021 10:09
@PiDelport PiDelport marked this pull request as ready for review June 21, 2021 10:09
@PiDelport
Copy link
Collaborator Author

(Rebased to main after merge)

@PiDelport
Copy link
Collaborator Author

@longtomjr: Good idea, yeah!

@PiDelport PiDelport force-pushed the feat-more-enclave-messages branch from 67b48ac to 733e097 Compare June 21, 2021 12:00
@PiDelport PiDelport force-pushed the feat-more-enclave-messages branch from 733e097 to 77479a8 Compare June 21, 2021 12:04
@PiDelport
Copy link
Collaborator Author

@longtomjr: I factored out the enclaves' cbindgen config, and added documentation there: f1e3c1d, 61b48f3

How does that look?

@PiDelport PiDelport requested a review from longtomjr June 21, 2021 12:05
longtomjr
longtomjr approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@PiDelport PiDelport merged commit 2e14843 into main Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nghondzweni Nghondzweni Nghondzweni approved these changes

@longtomjr longtomjr longtomjr approved these changes

Assignees

@PiDelport PiDelport

Labels
M: types lib Module: Types library (rtc_types)
Projects
None yet
Milestone
Execute computations
Development

Successfully merging this pull request may close these issues.
3 participants
@PiDelport @longtomjr @Nghondzweni