This repository has been archived by the owner on May 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longtomjr
reviewed
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh, thanks, this looks really good.
PiDelport
force-pushed
the
style-format-imports
branch
2 times, most recently
from
June 15, 2021 13:11
1f75451
to
6114a0b
Compare
Okay, I went ahead and committed the formatted imports per top-level crate, roughly. We can commit this whenever least inconvenient: I'll be happy to update the open PRs once we do. |
PiDelport
force-pushed
the
style-format-imports
branch
5 times, most recently
from
June 21, 2021 13:10
d0573e2
to
8849cd1
Compare
longtomjr
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks much nicer!
PiDelport
force-pushed
the
style-format-imports
branch
from
June 25, 2021 12:52
8849cd1
to
cecd62c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.